Wrap concavehull
#218
Open
Wrap concavehull
#218
+562
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
|
Member
Author
|
The real reason I want this is to create stress tests for GeometryOps natural indexing. A polygon so generated will hopefully have a lot of spatially uncorrelated edges leading to large rectangles at the leaf level in the index... |
Member
Author
|
CI seems fine except for GeoInterfaceMakie issues... |
evetion
reviewed
Apr 20, 2025
Member
evetion
left a comment
evetion
left a comment
There was a problem hiding this comment.
Concave hull of polygons feels wrong to me, but it seems it's just wrapping libgeos here. It's for multigeometries I assume, returning multiple concave hulls?
Member
Author
|
I think it's more so that the erosion respects the borders of polygons as things that it should not erode. All of these methods are Delaunay erosion anyway... |
It should error according to the comment there
…er than references
Member
Author
|
CI is finally going! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what it says on the tin :)
Wraps
GEOSConcaveHullandGEOSConcaveHullByLengthin a single user accessible functionconcavehull, which requires a second real number argument.Also adds some convenience context to the tests on GI conversions so we can figure out which function is going wrong.
Fix #181